Lumen Variations #49
Merged
Lumen Variations #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end = parser.parse(cells[idx + 1].string.split(" GMT")[0]) | ||
| data["end"] = self.dt2ts(end) | ||
| break | ||
| if cells: |
There was a problem hiding this comment.
Can we invert this logic to reduce nesting?
if not cells:
continue
if cells[0].string == "Start" and cells[1].string == "End":
num_columns = 2
...| return [data] | ||
|
|
||
| except Exception as exc: | ||
| traceback.print_exc() |
There was a problem hiding this comment.
Should this be reverted? Or is it an intentional addition?
There was a problem hiding this comment.
Sorry, left over code. My bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at some email notifications I've spotted some varriations in the strings used to match data. There is also a possibility that a notification can have an empty table.
"scheduled maintenance #:"can sometimes be used to identify the ID, and"This maintenance is scheduled"can be used to find the status.Testing has been added to ensure these variations.