Fix Equinix Parser #143
Merged
Fix Equinix Parser #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadell
reviewed
May 11, 2022
| for b_elem in b_elements: | ||
| if "SPAN:" in b_elem.text: |
There was a problem hiding this comment.
why .text is needed here and not in the other if statements?
There was a problem hiding this comment.
the relevant text is in the text of the b element rather than next to the b element:
<b>SPAN: 02-JUL-2021 - 03-JUL-2021</b>
vs
<b>UTC:</b> FRIDAY, 02 JUL 10:00 - FRIDAY, 02 JUL 15:00
…t-parser into fix-equinix-ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142 .
The parser was failing due to the exclusion of the year of the maintenance in the timestamp. The detailed time from the notification does not include the year, which is listed on a different line.
This fix parses the start and end year and adds it to the start and end date/time to get an accurate timestamp.