Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fixes #127

Merged
merged 5 commits into from
Dec 9, 2021
Merged

More fixes #127

merged 5 commits into from
Dec 9, 2021

Conversation

glennmatthews
Copy link
Contributor

  • Some Equinix emails don't clearly state "SCHEDULED" or "COMPLETED" (etc.) in their subject - default status of these emails to CONFIRMED for lack of any better contextual information.
  • Lumen parser wasn't handling status Cancelled - add support for it.
  • I think I went a bit too far in Make 'status' optional, accept iCal notifications with no 'sequence' either #125 by defaulting status = Status.NO_CHANGE globally, it's better to keep it as something that will raise an error if the parser doesn't set an appropriate value for it.

chadell
chadell previously approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you update the Readme with the change on status?

chadell
chadell approved these changes Dec 9, 2021
View reviewed changes
Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pke11y
pke11y approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@pke11y pke11y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@glennmatthews glennmatthews merged commit 8ee467f into develop Dec 9, 2021
@glennmatthews glennmatthews deleted the gfm-more-fixes branch December 9, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pke11y pke11y pke11y approved these changes

@chadell chadell chadell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glennmatthews @chadell @pke11y