Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional status for Lumen #117

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Add additional status for Lumen #117

merged 3 commits into from
Nov 29, 2021

Conversation

pke11y
Copy link
Contributor

@pke11y pke11y commented Nov 25, 2021

This PR adds tests and fix for Lumen notifications with a status = Alternate Night

chadell
chadell previously approved these changes Nov 25, 2021
View reviewed changes
Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(remember to add all these changes to CHANGELOG.md)

@pke11y pke11y requested a review from chadell November 26, 2021 12:16
chadell
chadell approved these changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chadell chadell merged commit 007c2f5 into networktocode:develop Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadell chadell chadell approved these changes

@glennmatthews glennmatthews Awaiting requested review from glennmatthews glennmatthews is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pke11y @chadell