Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colt parsing updates #116

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Colt parsing updates #116

merged 2 commits into from
Nov 26, 2021

Conversation

pke11y
Copy link
Contributor

@pke11y pke11y commented Nov 24, 2021

This PR will add a new EmailSubject parser for Colt to account for cancellation notifications.

In addition, the existing SubjectParserColt1 will be updated to accommodate carriage returns in the regex used to extract the data from the subject.

A test email was created with Content-Transfer-Encoding: 7bit as seen in production to test the parsing of the cancellation notice.

Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! I would just suggest to add a specific test for the new subject parser in tests/unit/test_parsers.py

Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pke11y pke11y merged commit 6d9eb7a into networktocode:develop Nov 26, 2021
@pke11y pke11y deleted the colt-subject branch November 26, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants