Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equinix improvements #112

Merged
merged 3 commits into from
Nov 18, 2021
Merged

Equinix improvements #112

merged 3 commits into from
Nov 18, 2021

Conversation

glennmatthews
Copy link
Contributor

  • Avoid an undefined impact variable if the impact type is unrecognized (will likely still fail, but at least now we return a None rather than raising an exception)
  • Add recognition of reduced-redundancy as an impact type
  • Make the maintenance-id matching in the email subject line more conservative
  • Add an _include_filter to ignore other types of Equinix emails
  • Rename equinix3_result.json to equinix1_result_combined.json to more closely match its meaning and usage

@glennmatthews
Add example of reduced-redundancy Equinix notification, fix a corner …
9f92030 
…case with email subject matching and long subjects, add include_filter for Equinix
chadell
chadell previously approved these changes Nov 18, 2021
View reviewed changes
Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chadell
chadell approved these changes Nov 18, 2021
View reviewed changes
Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glennmatthews glennmatthews merged commit 2cbd97b into develop Nov 18, 2021
@glennmatthews glennmatthews deleted the gfm-improve-equinix branch November 18, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadell chadell chadell approved these changes

@pke11y pke11y Awaiting requested review from pke11y pke11y is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glennmatthews @chadell