Add parsers for Equinix maintenance notifications via email #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scetron
requested review from
chadell,
glennmatthews and
pke11y
as code owners
|
Looks like there are still some |
glennmatthews
approved these changes
Nov 1, 2021
Comment on lines
+59
to
+63
| # for non english equinix notifications | ||
| # english section is usually at the bottom | ||
| # this skips the non english line at the top | ||
| if not self._isascii(raw_time): | ||
| continue |
There was a problem hiding this comment.
This feels pretty fragile to me but we can go with it for now and fix later if it proves to be an issue.
There was a problem hiding this comment.
Agreed. Unfortunately seemed to be the best way to detect the non-english characters which don't encode to ascii. If they stop including English, this would break, but than we'd have a larger problem of localization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.