Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tzwhere.tzwhere() is called at import time, causing substantial memory overhead #121

Closed
glennmatthews opened this issue Nov 30, 2021 · 0 comments · Fixed by #122
Closed

tzwhere.tzwhere() is called at import time, causing substantial memory overhead #121

glennmatthews opened this issue Nov 30, 2021 · 0 comments · Fixed by #122
Assignees
@glennmatthews
Labels
type: bug

Comments

@glennmatthews
Copy link
Contributor

Environment

  • Python version:
  • circuit_maintenance_parser version: 2.0.4 and later

Expected Behavior

No significant increase in memory consumption when loading the circuit_maintenance_parser library after upgrading from 2.0.3 to 2.0.4

Observed Behavior

Memory usage jumps by over 400 MB after import circuit_maintenance_parser with 2.0.4.

This appears to be due to #104, specifically due to a Geolocator object being instantiated at library load time, which in turn calls tzwhere.tzwhere(), which appears to allocate a large amount of memory.

Steps to Reproduce

  1. python
  2. import circuit_maintenance_parser
@glennmatthews glennmatthews self-assigned this Nov 30, 2021
@glennmatthews glennmatthews changed the title tzwhere.tzwhere() is called at load time, causing substantial memory overhead tzwhere.tzwhere() is called at import time, causing substantial memory overhead Nov 30, 2021
glennmatthews added a commit that referenced this issue Nov 30, 2021
@glennmatthews
Fix #121 - defer loading of tzwhere until it's needed
927ae7f
@glennmatthews glennmatthews mentioned this issue Nov 30, 2021
Merged
@glennmatthews glennmatthews mentioned this issue Dec 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glennmatthews glennmatthews

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Defer loading of tzwhere until it's needed networktocode/circuit-maintenance-parser
1 participant
@glennmatthews