Logger refactoring #281
Open
Logger refactoring #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if the hacks are worth it. It may be better to only add StreamLogger and allow logger instance as alternative to log directory but do not modify the Logger at all. And possibly release the refactored logger in the future with BC breaks as part of Tracy 3. |
f3l1x
reviewed
Feb 20, 2018
| ) { | ||
| call_user_func($this->mailer, $message, implode(', ', (array) $this->email)); | ||
| } | ||
| $reflection = new \ReflectionMethod($this->mailLogger, 'sendEmail'); |
There was a problem hiding this comment.
Why is reflection needed? If MailLogger is not interface, it might have sendEmail public. WDYT?
|
I like this PR, maybe it could be more cleaner (without hacks) for nette 3.0? If we break the API, let's make better one. |
dg
force-pushed
the
master
branch
4 times, most recently
from
d13a9ce to
7f24887
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
427177a to
7ac33a2
Compare
dg
force-pushed
the
master
branch
15 times, most recently
from
4dc8213 to
d53b9c3
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
34992a5 to
7e8d83f
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
53883a2 to
e26bb83
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
ed50c8c to
1a1cfeb
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
e978bbc to
f8e0f10
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
866bd61 to
7dd88f7
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
b39998b to
5906211
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
e89fde9 to
5718904
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
33ec3c4 to
8d3f47d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #280 with lots of hack to maintain compatibility.