This repository has been archived by the owner on May 22, 2024. It is now read-only.
chore: fix calculation of average in benchmark #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
commented
Oct 31, 2022
| export const timeFunction = async (func, runs = 1) => { | ||
| const finishedRuns = new Map() | ||
|
|
||
| performance.clearMarks() | ||
| performance.clearMeasures() |
There was a problem hiding this comment.
Not strictly necessary but if we run multiple benchmarks after each other, this is critical. Anyway it doesn't hurt.
danez
commented
Oct 31, 2022
| await Promise.all( | ||
| Array.from({ length: runs }).map(async (_, index) => { | ||
| performance.mark(`run-${index}-start`) | ||
| for (let index = 0; index < runs; index++) { |
There was a problem hiding this comment.
Use for loop so that the runs are not running in parallel, which I guess where the reason for the change in the timings here in the github action.
⏱ Benchmark resultsComparing with 53d6526 largeDepsEsbuild: 2.3s⬇️ 106.94% decrease vs. 53d6526 LegendlargeDepsNft: 10.8s⬇️ 135.52% decrease vs. 53d6526 LegendlargeDepsZisi: 15.9s⬇️ 12.68% decrease vs. 53d6526 |
danez
commented
Oct 31, 2022
| }), | ||
| ) | ||
| // wait for PerformanceObserver to gather all data | ||
| await sleep(100) |
There was a problem hiding this comment.
As the PerformanceObserver is triggered async, we need to wait till it was triggered.
Right now out of the 3 runs we usually only calculate the average with the numbers of 2 runs but divide it by 3. So the number is completely off.
The assert a little down is also there to ensure we captured all runs.
danez
commented
Oct 31, 2022
|
|
||
| const durations = [...finishedRuns.values()] | ||
|
|
||
| observer.disconnect() |
There was a problem hiding this comment.
disconnect it, just in the case we run multiple benchmarks, so that we do not have multiple observers observing.
danez
changed the title
5 tasks
khendrikse
approved these changes
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See inline comments
For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)