Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove classic env var references in endpoint descriptions #545

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

JGAntunes
Copy link
Contributor

No description provided.

@JGAntunes JGAntunes requested review from a team as code owners July 24, 2024 15:05
@JGAntunes JGAntunes self-assigned this Jul 24, 2024
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for open-api ready!

Name Link
🔨 Latest commit 6900122
🔍 Latest deploy log https://app.netlify.com/sites/open-api/deploys/66a1181ec696dc0008f00f86
😎 Deploy Preview https://deploy-preview-545--open-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JGAntunes JGAntunes requested a review from codebyuma July 24, 2024 15:05
@JGAntunes JGAntunes enabled auto-merge (squash) July 24, 2024 15:05
Copy link
Contributor

@codebyuma codebyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed one minor thing but, otherwise, this looks good to go.

Thank you for fixing this!!

@@ -521,8 +516,7 @@ paths:
default:
$ref: '#/responses/error'
description: >-
Deletes an environment variable. To use this endpoint, your site must no
longer be using the <a href="https://docs.netlify.com/environment-variables/classic-experience/">classic environment variables experience</a>. Migrate now with the Netlify UI.
Deletes an environment variable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing a period at the end here

Suggested change
Deletes an environment variable
Deletes an environment variable.

@JGAntunes JGAntunes merged commit 511fd7b into master Jul 24, 2024
14 of 15 checks passed
@JGAntunes JGAntunes deleted the chore/remove-classic-env-var-ref branch July 24, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants