-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service worker prevents function calls #2
Comments
Removed unnecessary css files
Hi Lars, sorry for the super super late response. i just joined the team. Its been a long while so I'm gonna assume this is stale. but if you still need this looked at please feel free to reopen! |
Hi Shawn, thanks for your response. I think this is still relevant as this boilerplate will not work like this. Please correct me if I'm wrong. :) Only solution for me was to eject and adjust the webpack config. |
i mean for what its worth the service worker is off by default in CRA v2. i never use it. |
This wasn't the case for v1. :) I'd suggest adding a note to the README to prevent other people from running into the same problem. I'm willing to create a PR if you like. |
Add note about service worker usage #2
As the service worker seems to be the "official" one I assume it can't be used like this in combination with functions.
facebook/create-react-app#2237 (comment)
The Service worker will just return the app instead of the function itself. Only option is ejecting and extend
navigateFallbackWhitelist
option.I didn't test this with this package, but with a bare CRA app and functions which should be basically the same.
The text was updated successfully, but these errors were encountered: