Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add the Dart Sass Embedded binary #740

Open
bep opened this issue Feb 11, 2022 · 1 comment
Open

Add the Dart Sass Embedded binary #740

bep opened this issue Feb 11, 2022 · 1 comment
Labels
good first issue type: bug code to address defects in shipped code

Comments

@bep
Copy link

bep commented Feb 11, 2022

See https://discourse.gohugo.io/t/using-dart-sass-hugo-and-netlify/37099/2 for some context.

I'm the lead maintainer of Hugo. We integrate with both LibSASS (now deprecated) and Dart SASS via the embedded protocol. This all works great, but the latter requires a binary to be present in the PATH. I have looked, and I think even the Node library requires an extra download step by the end user.

Anyway, I don't know of any simple AND safe way to provide this from the Hugo executable and for me this looks like a peer dependency simliar to Go, Node, Ruby and other. It would be great if Netlify could install this as part of the default build setup (the binary is very small) and allow end users to select a version, e.g. via DARTSASS_VERSION.

@bep bep added the type: bug code to address defects in shipped code label Feb 11, 2022
@ingride
Copy link
Contributor

ingride commented Feb 21, 2022

hi @bep! Thank you for the suggestion and all the details. You can open a PR and make this change following the contribution guildelines , and we are here to support if you run into any issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue type: bug code to address defects in shipped code
Projects
None yet
Development

No branches or pull requests

2 participants