Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ingestion processing cleanup #209

Merged
merged 5 commits into from
Dec 23, 2024
Merged

chore: ingestion processing cleanup #209

merged 5 commits into from
Dec 23, 2024

Conversation

ltucker
Copy link
Contributor

@ltucker ltucker commented Dec 23, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/gen/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.21s github.com/netboxlabs/diode/diode-server/ingester 71.2% 9 0 0
🟢 PASS 1.04s github.com/netboxlabs/diode/diode-server/migrator 68.2% 4 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.61s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 78.9% 42 0 0
🟢 PASS 1.46s github.com/netboxlabs/diode/diode-server/reconciler 83.6% 49 0 0
🟢 PASS 1.09s github.com/netboxlabs/diode/diode-server/reconciler/applier 81.8% 1 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/reconciler/changeset 0.0% 0 0 0
🟢 PASS 1.31s github.com/netboxlabs/diode/diode-server/reconciler/differ 80.3% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 74.9%

@ltucker ltucker closed this Dec 23, 2024
@ltucker ltucker deleted the rpc_actioningestionlog_diff branch December 23, 2024 16:03
@ltucker ltucker restored the rpc_actioningestionlog_diff branch December 23, 2024 17:25
@ltucker ltucker reopened this Dec 23, 2024
@ltucker ltucker force-pushed the rpc_actioningestionlog_diff branch from 377dc45 to 7efa321 Compare December 23, 2024 17:30
@ltucker ltucker changed the title feat:rpc actioningestionlog diff chore:ingestion processing cleanup Dec 23, 2024
@ltucker ltucker closed this Dec 23, 2024
@ltucker ltucker deleted the rpc_actioningestionlog_diff branch December 23, 2024 17:34
@ltucker ltucker restored the rpc_actioningestionlog_diff branch December 23, 2024 17:37
@ltucker ltucker reopened this Dec 23, 2024
@ltucker ltucker changed the base branch from feat-netbox-assurance to feat-postgres-implementation-and-enhancements December 23, 2024 17:37
@ltucker ltucker force-pushed the rpc_actioningestionlog_diff branch from 7efa321 to debebfa Compare December 23, 2024 17:43
@ltucker ltucker marked this pull request as ready for review December 23, 2024 18:14
mfiedorowicz
mfiedorowicz approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Luke, lots of great improvements 👏

A few tiny asks to consider.

diode-server/gen/dbstore/postgres/adapters.go Outdated Show resolved Hide resolved
diode-server/dbstore/postgres/repository.go Outdated Show resolved Hide resolved
diode-server/dbstore/postgres/repository.go
if err != nil {
return nil, nil, err
}
return &ingestionLog.ID, log, nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's introduce service layer struct to abstract proto types as args and return types in a separate PR.

@mfiedorowicz mfiedorowicz changed the title chore:ingestion processing cleanup chore: ingestion processing cleanup Dec 23, 2024
@ltucker ltucker merged commit 252498e into feat-postgres-implementation-and-enhancements Dec 23, 2024
3 checks passed
@ltucker ltucker deleted the rpc_actioningestionlog_diff branch December 23, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoparente leoparente leoparente approved these changes

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

Assignees
No one assigned
Labels
diode-ingester diode-proto diode-reconciler diode-server go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ltucker @mfiedorowicz @leoparente