Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #12226: Add Profile Data Headers to Remote Authentication Middleware #12253

Conversation

stuntguy3000
Copy link
Contributor

Fixes: #12226

This change introduces a new set of optional headers which update the user's profile when using Remote Authentication.

The original issue references specifically first names, however this change looks at the whole user's profile.

@heapdavid
Copy link

Quick note from the original request, it was Full Name rather than First Name - are they separate fields in the db? Most auth providers send the full name as one field.

@stuntguy3000
Copy link
Contributor Author

That's my understanding of the data structure. Perhaps we could add a full name field and transpose it? But that the leaves it up to interpretation of how to split a name.

@kkthxbye-code
Copy link
Contributor

it was Full Name rather than First Name - are they separate fields in the db?

https://docs.djangoproject.com/en/4.2/ref/contrib/auth/#django.contrib.auth.models.User.first_name

They are separate fields.

@heapdavid
Copy link

Ah yeah that looks to be the case. That's a tough one isn't it - so many different formats of name!

@heapdavid
Copy link

Apologies, it looks like we can get first and last name fields from our auth providers separately, so should be fine to proceed as is.

@jeremystretch jeremystretch merged commit ab35315 into netbox-community:develop Apr 20, 2023
@jeremystretch
Copy link
Member

Thanks @stuntguy3000!

@stuntguy3000 stuntguy3000 deleted the 12226-add-profile-headers-to-remote-auth branch April 20, 2023 23:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Full Name to be set by remote authentication
4 participants