-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #10987: Show rack-list dropdown in rack #11779
Fixes #10987: Show rack-list dropdown in rack #11779
Conversation
@jeremystretch Is this ok ? or does it need improvement |
This doesn't appear to be finished; you're still rendering both approaches in the template. Only a dropdown list would be viable here, because rendering a static list of racks could easily disrupt the page layout. |
The dropdown is shown when the view goes in 'mobile' mode. I do like that static list, as it navigates faster than the dropdown list.. |
I'm afraid the static list is a nonstarter. It looks reasonable in your example with extremely short rack names, but is not tenable with even moderately long rack names, or with many peer racks. The only workable solution is a dropdown selector. |
Thanks @PieterL75! |
Fixes #10987: Show rack-list dropdown in rack