Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10987: Show rack-list dropdown in rack #11779

Merged

Conversation

PieterL75
Copy link
Contributor

Fixes #10987: Show rack-list dropdown in rack

@PieterL75
Copy link
Contributor Author

PieterL75 commented Feb 17, 2023

There are currently 2 types of navigation.
Maybe we can make it dynamic. So that the short one is shown on small devices, and the bar on desktop views ?
image

image

@PieterL75
Copy link
Contributor Author

I got the resize working (using BS5 classes)
image
and
image

@PieterL75
Copy link
Contributor Author

@jeremystretch Is this ok ? or does it need improvement

@jeremystretch
Copy link
Member

This doesn't appear to be finished; you're still rendering both approaches in the template. Only a dropdown list would be viable here, because rendering a static list of racks could easily disrupt the page layout.

@PieterL75
Copy link
Contributor Author

The dropdown is shown when the view goes in 'mobile' mode.
The static list is show in desktop mode..

I do like that static list, as it navigates faster than the dropdown list..
I might make it slide to 2 rows when the screen gets to small...

@jeremystretch
Copy link
Member

I'm afraid the static list is a nonstarter. It looks reasonable in your example with extremely short rack names, but is not tenable with even moderately long rack names, or with many peer racks. The only workable solution is a dropdown selector.

@jeremystretch
Copy link
Member

Thanks @PieterL75!

@jeremystretch jeremystretch merged commit b693123 into netbox-community:develop Apr 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show rack-list dropdown in rack view
2 participants