Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect disk size unit when bulk editing VMs #17986

Closed
lassebm opened this issue Nov 11, 2024 · 0 comments · Fixed by #17992
Closed

Incorrect disk size unit when bulk editing VMs #17986

lassebm opened this issue Nov 11, 2024 · 0 comments · Fixed by #17992
Assignees
@jeremystretch
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@lassebm
Copy link
Contributor

lassebm commented Nov 11, 2024

Deployment Type

Self-hosted

Triage priority

I volunteer to perform this work (if approved)

NetBox Version

v4.1.6

Python Version

3.12

Steps to Reproduce

  1. Create VM
  2. Bulk edit VM

Expected Behavior

"MB" unit shown for disk size in bulk edit form, as this is the unit for disk size in NetBox >= 4.1

Observed Behavior

"GB" unit shown for disk size in bulk edit form.
@lassebm lassebm added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Nov 11, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Nov 12, 2024
@jeremystretch jeremystretch self-assigned this Nov 12, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Nov 12, 2024
jeremystretch added a commit that referenced this issue Nov 12, 2024
@jeremystretch
Fixes #17986: Correct label for disk size when bulk editing virtual m…
ee38f14 
…achines
@jeremystretch jeremystretch mentioned this issue Nov 12, 2024
Merged
jeremystretch added a commit that referenced this issue Nov 12, 2024
@jeremystretch
Fixes #17986: Correct label for disk size when bulk editing virtual m…
9c532c7 
…achines (#17992)

* Fixes #17986: Correct label for disk size when bulk editing virtual machines

* Correct label for VirtualDisk.size
jsenecal pushed a commit to jsenecal/netbox that referenced this issue Nov 12, 2024
@jeremystretch @jsenecal
Fixes netbox-community#17986: Correct label for disk size when bulk e…
48b1c7b 
…diting virtual machines (netbox-community#17992)

* Fixes netbox-community#17986: Correct label for disk size when bulk editing virtual machines

* Correct label for VirtualDisk.size
This was referenced Nov 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremystretch jeremystretch

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #17986: Correct label for disk size when bulk editing virtual machines netbox-community/netbox
2 participants
@lassebm @jeremystretch