Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain characters are incorrectly escaped when rendering custom links #12355

Closed
jeremystretch opened this issue Apr 26, 2023 · 0 comments · Fixed by #12358
Closed

Certain characters are incorrectly escaped when rendering custom links #12355

jeremystretch opened this issue Apr 26, 2023 · 0 comments · Fixed by #12358
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Member

NetBox version

v3.4.9

Python version

3.8

Steps to Reproduce

  1. Create a custom link with the URL http://example.com/?foo=1&bar=2
  2. View an object where the custom link appears and inspect its source

Expected Behavior

The unmodified URL should be present.

Observed Behavior

The link is incorrectly escaped to http://example.com/?foo%3D1&bar%3D2. This is a regression resulting from 89fa546.
@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 26, 2023
@jeremystretch jeremystretch mentioned this issue Apr 26, 2023
Closed
x64x6a added a commit to x64x6a/netbox that referenced this issue Apr 26, 2023
@x64x6a
Fixes netbox-community#12355: Exclude extra characters from url encode
b4fb69e
x64x6a added a commit to x64x6a/netbox that referenced this issue Apr 26, 2023
@x64x6a
Fixes netbox-community#12355: Exclude additional characters from url …
a5e5021 
…encode
@x64x6a x64x6a mentioned this issue Apr 26, 2023
Merged
x64x6a added a commit to x64x6a/netbox that referenced this issue Apr 26, 2023
@x64x6a
Fixes netbox-community#12355: Exclude additional characters from url …
4355085 
…encode
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Apr 27, 2023
@jeremystretch jeremystretch mentioned this issue Apr 27, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add additional characters to exclude from url encode x64x6a/netbox
1 participant
@jeremystretch