Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inventory item cannot be reassgined to another device #12255

Closed
ntopee opened this issue Apr 14, 2023 · 1 comment · Fixed by #12311
Closed

Inventory item cannot be reassgined to another device #12255

ntopee opened this issue Apr 14, 2023 · 1 comment · Fixed by #12311
Assignees
@arthanson
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@ntopee
Copy link

ntopee commented Apr 14, 2023 •
edited
Loading

NetBox version

v3.4.8

Python version

3.8

Steps to Reproduce

  1. Click on Edit on any inventory item in the UI
  2. Edit Device field
  3. Click save

Expected Behavior

The inventory item should be assigned to the selected device.

Observed Behavior

"Components cannot be moved to a different device." validation error is shown
This validation is introduced in #11567 , but I don't think the change that even inventory items cannot be reassigned to another device via the UI was intended.
@ntopee ntopee added the type: bug A confirmed report of unexpected behavior in the application label Apr 14, 2023
@kkthxbye-code kkthxbye-code added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 14, 2023
@kkthxbye-code
Copy link
Contributor

but I don't think the change that even inventory items cannot be reassigned to another device via the UI was intended.

Correct, it was specified in both the original issue and a comment to the PR, that it was to only apply to InterfaceComponents other than InterfaceItem. Not sure what went wrong here.

@arthanson

@matejv matejv mentioned this issue Apr 17, 2023
Closed
arthanson added a commit that referenced this issue Apr 19, 2023
@arthanson
#12255 allow inventory items to change devices
f3413e1
arthanson added a commit that referenced this issue Apr 19, 2023
@arthanson
#12255 allow inventory item template to change devices
700ee12
arthanson added a commit that referenced this issue Apr 19, 2023
@arthanson
#12255 fix init
268f894
@arthanson arthanson self-assigned this Apr 19, 2023
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 19, 2023
@arthanson arthanson mentioned this issue Apr 20, 2023
Merged
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Apr 21, 2023
jeremystretch pushed a commit that referenced this issue Apr 21, 2023
@arthanson
12255 inventory item device change (#12311)
38a0ed5 
* #12255 allow inventory items to change devices

* #12255 allow inventory item template to change devices

* #12255 fix init

* 12255 remove can_swtich from template model

* 12255 change to check module list
jeremystretch added a commit that referenced this issue Apr 21, 2023
@jeremystretch
Changelog for #11383, #12205, #12226, #12255
390619c
@jeremystretch jeremystretch mentioned this issue Apr 26, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

12255 inventory item device change netbox-community/netbox
4 participants
@arthanson @kkthxbye-code @jeremystretch @ntopee