Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import of Inventory Items fails when multiple devices with same name exists #11902

Closed
AnythingOverIP opened this issue Mar 3, 2023 · 1 comment · Fixed by #12345
Closed

Import of Inventory Items fails when multiple devices with same name exists #11902

AnythingOverIP opened this issue Mar 3, 2023 · 1 comment · Fixed by #12345
Assignees
@arthanson
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@AnythingOverIP
Copy link

AnythingOverIP commented Mar 3, 2023 •
edited
Loading

NetBox version

v3.4.3

Python version

3.8

Steps to Reproduce

  1. Create a device with name "test" in a site (i.e. Site_A)
  2. Create a second device with same name in another site (i.e. Site_B)
  3. Create a simple bulk import :

       device,name,serial
       test,hard_disk,12345
  1. Submit via /dcim/inventory-items/import/

Expected Behavior

A warning toast notification should tell us that import line 1 has more than one "target".

Observed Behavior

InventoryItem has no device:
image

When you load multiple lines, it's not telling you where the issue is.

Ideally, there should be a site field in the import options to ensure we target the right device.
@AnythingOverIP AnythingOverIP added the type: bug A confirmed report of unexpected behavior in the application label Mar 3, 2023
@AnythingOverIP
Copy link
Author

Same behavior if the device listed in the bulk import does not exists. Server Error instead of toast notification.

@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Mar 7, 2023
@arthanson arthanson self-assigned this Apr 19, 2023
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 19, 2023
@arthanson arthanson removed their assignment Apr 21, 2023
@arthanson arthanson added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 21, 2023
@arthanson arthanson self-assigned this Apr 25, 2023
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 25, 2023
arthanson added a commit that referenced this issue Apr 25, 2023
@arthanson
#11902 validate device on inventory item import
d9f2125
@arthanson arthanson mentioned this issue Apr 25, 2023
Merged
jeremystretch pushed a commit that referenced this issue Apr 26, 2023
@arthanson @jeremystretch
#11902 validate device on inventory item import
1ad0297
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Apr 26, 2023
@jeremystretch jeremystretch mentioned this issue Apr 26, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#11902 validate device on inventory item import netbox-community/netbox
3 participants
@arthanson @jeremystretch @AnythingOverIP