-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented support for proxydhcp variables (disbaled by default) #953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a few changes but I think the general idea makes sense.
…into development Merging upstream updates into local repo
…from BIOS netinfo as it isn't supported
…ome BIOS implementations
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sorry for the late reply, I was tageled up in tape drive stuff (heh). |
Have finally got around to setting up an environment to test with proxy working, so merging this in as is to build some images with it, test, and tune. I think the menu vars need to be reworked a bit as proxydhcp isn't a var thats set that's set but overall looks good. This should at least get us some builds to test and iterate on. |
I've implemented the feature requested in #952
I'm not entirely sure if the type of implementation matches what the project wants. By default netboot.xyz will behave the same as before. Only after a change to "proxy-dhcp-vars.ipxe" is made, the new logic will be enabled.
The overall logic is as follows:
This logic could be simplified by removing the additional config file, but than there could be changes for the end user (e.g. the newly added prompt), or the proxydhcp could be used whenever it is detected. The code can be changed to do either of this, I'm completely open for feedback on this.
Edit: The changes currently only impact UEFI booting, as BIOS booting doesn't seem to have access to proxydhcp info