Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typings for PassportStrategy #134

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Conversation

NickBolles
Copy link
Contributor

Return the instance type instead of the class type, this allows for intellisense to find the authenticate and other functions

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

this could almost be an enhancement though...

What is the current behavior?

Issue Number: N/A

What is the new behavior?

correct intellisense on strategy services, especially in unit tests

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Return the instance type instead of the class type, this allows for intellisense to find the `authenticate` and other functions
@kamilmysliwiec kamilmysliwiec merged commit e821c87 into nestjs:master Nov 28, 2019
@kamilmysliwiec
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants