fixup! perf: prefer use factory instead of use value when possible

nestjs · Nov 17, 2023 · 9a1ea46 · 9a1ea46
1 parent 8a2d19d
commit 9a1ea46
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 10 deletions.
diff --git a/packages/common/module-utils/configurable-module.builder.ts b/packages/common/module-utils/configurable-module.builder.ts
@@ -209,8 +209,6 @@ export class ConfigurableModuleBuilder<
         const providers: Array<Provider> = [
           {
             provide: self.options.optionsInjectionToken,
-            // useFactory is for performance reasons
-            // see more: https://github.com/nestjs/nest/issues/12738#issuecomment-1810987001
             useFactory: () => this.omitExtras(options, self.extras),
           },
         ];

diff --git a/packages/core/injector/internal-core-module/internal-core-module-factory.ts b/packages/core/injector/internal-core-module/internal-core-module-factory.ts
@@ -42,8 +42,6 @@ export class InternalCoreModuleFactory {
       );
     };
 
-    // useFactory is for performance reasons
-    // see more: https://github.com/nestjs/nest/issues/12738#issuecomment-1810987001
     return InternalCoreModule.register([
       {
         provide: ExternalContextCreator,

diff --git a/packages/core/router/router-module.ts b/packages/core/router/router-module.ts
@@ -32,8 +32,6 @@ export class RouterModule {
       providers: [
         {
           provide: ROUTES,
-          // useFactory is for performance reasons
-          // see more: https://github.com/nestjs/nest/issues/12738#issuecomment-1810987001
           useFactory: () => routes,
         },
       ],

diff --git a/packages/microservices/module/clients.module.ts b/packages/microservices/module/clients.module.ts
@@ -19,8 +19,6 @@ export class ClientsModule {
     const clientsOptions = !Array.isArray(options) ? options.clients : options;
     const clients = (clientsOptions || []).map(item => ({
       provide: item.name,
-      // useFactory is for performance reasons
-      // see more: https://github.com/nestjs/nest/issues/12738#issuecomment-1810987001
       useFactory: () =>
         this.assignOnAppShutdownHook(ClientProxyFactory.create(item)),
     }));

diff --git a/packages/platform-express/multer/multer.module.ts b/packages/platform-express/multer/multer.module.ts
@@ -17,8 +17,6 @@ export class MulterModule {
     return {
       module: MulterModule,
       providers: [
-        // useFactory is for performance reasons
-        // see more: https://github.com/nestjs/nest/issues/12738#issuecomment-1810987001
         { provide: MULTER_MODULE_OPTIONS, useFactory: () => options },
         {
           provide: MULTER_MODULE_ID,