perf: prefer use factory instead of use value when possible

nestjs · Nov 15, 2023 · 53d2094 · 53d2094
1 parent ef53448
commit 53d2094
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/packages/common/module-utils/configurable-module.builder.ts b/packages/common/module-utils/configurable-module.builder.ts
@@ -209,7 +209,7 @@ export class ConfigurableModuleBuilder<
         const providers: Array<Provider> = [
           {
             provide: self.options.optionsInjectionToken,
-            useValue: this.omitExtras(options, self.extras),
+            useFactory: () => this.omitExtras(options, self.extras),
           },
         ];
         if (self.options.alwaysTransient) {

diff --git a/packages/core/injector/internal-core-module/internal-core-module-factory.ts b/packages/core/injector/internal-core-module/internal-core-module-factory.ts
@@ -45,23 +45,23 @@ export class InternalCoreModuleFactory {
     return InternalCoreModule.register([
       {
         provide: ExternalContextCreator,
-        useValue: ExternalContextCreator.fromContainer(container),
+        useFactory: () => ExternalContextCreator.fromContainer(container),
       },
       {
         provide: ModulesContainer,
-        useValue: container.getModules(),
+        useFactory: () => container.getModules(),
       },
       {
         provide: HttpAdapterHost,
-        useValue: httpAdapterHost,
+        useFactory: () => httpAdapterHost,
       },
       {
         provide: LazyModuleLoader,
         useFactory: lazyModuleLoaderFactory,
       },
       {
         provide: SerializedGraph,
-        useValue: container.serializedGraph,
+        useFactory: () => container.serializedGraph,
       },
     ]);
   }

diff --git a/packages/core/router/router-module.ts b/packages/core/router/router-module.ts
@@ -32,7 +32,7 @@ export class RouterModule {
       providers: [
         {
           provide: ROUTES,
-          useValue: routes,
+          useFactory: () => routes,
         },
       ],
     };

diff --git a/packages/microservices/module/clients.module.ts b/packages/microservices/module/clients.module.ts
@@ -19,7 +19,8 @@ export class ClientsModule {
     const clientsOptions = !Array.isArray(options) ? options.clients : options;
     const clients = (clientsOptions || []).map(item => ({
       provide: item.name,
-      useValue: this.assignOnAppShutdownHook(ClientProxyFactory.create(item)),
+      useFactory: () =>
+        this.assignOnAppShutdownHook(ClientProxyFactory.create(item)),
     }));
     return {
       module: ClientsModule,

diff --git a/packages/platform-express/multer/multer.module.ts b/packages/platform-express/multer/multer.module.ts
@@ -17,7 +17,7 @@ export class MulterModule {
     return {
       module: MulterModule,
       providers: [
-        { provide: MULTER_MODULE_OPTIONS, useValue: options },
+        { provide: MULTER_MODULE_OPTIONS, useFactory: () => options },
         {
           provide: MULTER_MODULE_ID,
           useValue: randomStringGenerator(),