-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Need Migration] Improve query performance of get_cells
in rich-indexer
#4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanYuan
requested review from
quake and
zhangsoledad
and removed request for
a team
July 1, 2024 02:40
eval-exec
reviewed
Jul 1, 2024
eval-exec
added
t:performance
Type: Performance tuning
m:indexer
module: ckb-indexer
labels
Jul 1, 2024
eval-exec
changed the title
Improve query performance of
[Need Migration] Improve query performance of Jul 18, 2024
get_cells
in rich-indexerget_cells
in rich-indexer
zhangsoledad
approved these changes
Sep 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When querying Rich Indexer
get_cells
orget_cells_capacity
, if there are too many DEAD cells under the specified address, it will pull down the performance of the query.What is changed and how it works?
What's Changed:
is_spent
to theoutput
table to know if the cell is live or dead without having to join theinput
table.Bitmap Heap Scan on output (cost=220.41..45166.83 rows=61 width=58) (actual time=0.953..3.456 rows=120 loops=1)
showsthat the number of rows scanned has become less.
The previous scan was:
Bitmap Heap Scan on output (cost=223.46..45139.27 rows=12244 width=58) (actual time=2.271..245.854 rows=692 loops=1)
Check List
Tests
Release note