Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rich indexer partial query by args performance issue #4484

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Fix rich indexer partial query by args performance issue #4484

merged 5 commits into from
Jun 19, 2024

Conversation

EthanYuan
Copy link
Collaborator

@EthanYuan EthanYuan commented Jun 17, 2024 •
edited
Loading

What problem does this PR solve?

Problem Summary:

What is changed and how it works?

What's Changed:

  • use LIKE instead of position func for PostgreSQL to avoid performance issues
  • The README has been updated to emphasize the software and hardware requirements.

Check List

Tests

  • Unit test
  • Manual test

Release note 

Title Only: Include only the PR title in the release note.

EthanYuan added 3 commits June 17, 2024 10:39
@EthanYuan
fix postgres: use instead of to avoid performance issues.
4964299
@EthanYuan
Appending a block might fail, particularly in scenarios where the har…
9502271 
…dware capabilities are significantly limited. Under such conditions, executing complex queries concurrently can lead to prolonged table locking, which in turn increases the likelihood of insertion failures.
@EthanYuan
PostgreSQL 16 supports hexadecimal, octal, and binary integer literal…
52269fc 
…s as 0x, 0o, and 0b prefixes.
@EthanYuan EthanYuan requested a review from a team as a code owner June 17, 2024 03:33
@EthanYuan EthanYuan requested review from zhangsoledad and quake and removed request for a team June 17, 2024 03:33
@EthanYuan EthanYuan changed the title Fix rich indexer partial query byperformance Fix rich indexer partial query by args performance issue Jun 17, 2024
@homura homura mentioned this pull request Jun 17, 2024
Open
@zhangsoledad zhangsoledad added this pull request to the merge queue Jun 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 19, 2024
@zhangsoledad zhangsoledad added this pull request to the merge queue Jun 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 19, 2024
@zhangsoledad zhangsoledad enabled auto-merge June 19, 2024 09:12
@zhangsoledad zhangsoledad added this pull request to the merge queue Jun 19, 2024
Merged via the queue into nervosnetwork:develop with commit 7db9023 Jun 19, 2024
31 checks passed
@EthanYuan EthanYuan deleted the fix-rich-indexer-partial-query branch July 26, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@driftluo driftluo driftluo approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@quake quake Awaiting requested review from quake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EthanYuan @zhangsoledad @driftluo @eval-exec