Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let crate ckb-hash support no-std #4002

Merged

Conversation

yangby-cryptape
Copy link
Collaborator

What problem does this PR solve?

Let ckb-hash support no-std, so developers don't have to copy constants again and again when write CKB contracts with Rust, such as CKB_HASH_PERSONALIZATION, to avoid typos.

For examples:

What is changed and how it works?

Both blake2b-rs (when cfg(not(target_arch = "wasm32"))) and blake2b-ref (when cfg(target_arch = "wasm32")) are support no-std with default features.

So, just adding #![no_std] is enough.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note

Title Only: Include only the PR title in the release note.

@yangby-cryptape yangby-cryptape requested a review from a team as a code owner June 7, 2023 06:57
@yangby-cryptape yangby-cryptape requested review from doitian and removed request for a team June 7, 2023 06:57
@yangby-cryptape yangby-cryptape requested a review from driftluo June 7, 2023 06:59
@quake quake added this pull request to the merge queue Jun 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 7, 2023
@yangby-cryptape yangby-cryptape added this pull request to the merge queue Jun 7, 2023
Merged via the queue into nervosnetwork:develop with commit ed80d4d Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants