Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove ckb db-repair subcommand #3927

Merged
merged 1 commit into from
Apr 14, 2023
Merged

feat: Remove ckb db-repair subcommand #3927

merged 1 commit into from
Apr 14, 2023

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Apr 8, 2023 •
edited
Loading

What problem does this PR solve?

https://github.com/facebook/rocksdb/wiki/RocksDB-Repairer#limitations

The repair provided by rocksdb is of little practical use and risks corrupting data.

What is changed and how it works?

Remove ckb db-repair subcommand

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner April 8, 2023 12:06
@zhangsoledad zhangsoledad requested review from doitian and removed request for a team April 8, 2023 12:06
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/remove-repair branch from dbeda66 to 11b8442 Compare April 8, 2023 12:16
eval-exec
eval-exec approved these changes Apr 8, 2023
View reviewed changes
Copy link
Collaborator

@eval-exec eval-exec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about change the PR title to: "Remove ckb db-repair subcommand", since the PR title will be shown in the release note.

@zhangsoledad zhangsoledad changed the title feat: remove repair feat: Remove ckb db-repair subcommand Apr 8, 2023
@quake quake added this pull request to the merge queue Apr 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Apr 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2023
@quake
Copy link
Member

quake commented Apr 11, 2023

merge failed:

error[yanked]: detected yanked crate
    ┌─ /home/runner/work/ckb/ckb/Cargo.lock:134:1
    │
134 │ crossbeam-channel 0.5.7 registry+https://github.com/rust-lang/crates.io-index
    │ ----------------------------------------------------------------------------- yanked version

could you upgrade the crossbeam-channel crate version in this PR together?

chenyukang
chenyukang reviewed Apr 12, 2023
View reviewed changes
db/src/read_only_db.rs
See https://github.com/facebook/rocksdb/wiki/RocksDB-Repairer for detail",
err_str
);
info!("DB corrupted: {err_str}.");
Copy link
Collaborator

@chenyukang chenyukang Apr 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we remove db-repair,
any other follow-up actions should be shown here to guide users to resolve it.

@zhangsoledad zhangsoledad mentioned this pull request Apr 12, 2023
Closed
@doitian doitian mentioned this pull request Apr 13, 2023
Closed
3 tasks
@quake quake added this pull request to the merge queue Apr 14, 2023
Merged via the queue into nervosnetwork:develop with commit 9d019a9 Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyukang chenyukang chenyukang left review comments

@eval-exec eval-exec eval-exec approved these changes

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangsoledad @quake @chenyukang @eval-exec