Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix transaction rebroadcast by resubmitting #3840

Merged
merged 2 commits into from
Feb 26, 2023
Merged

fix transaction rebroadcast by resubmitting #3840

merged 2 commits into from
Feb 26, 2023

Conversation

zhangsoledad
Copy link
Member

What problem does this PR solve?

When a transaction fails a double-spend check, it is still marked as known, making it impossible to rebroadcast by resubmitting

What is changed and how it works?

Ensure that if a transaction can be rebroadcast in case of verification failure, it should be removed from the known filter。

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner February 15, 2023 15:00
@zhangsoledad zhangsoledad requested review from quake and removed request for a team February 15, 2023 15:00
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/notify_reject branch from 3f42582 to 92b2286 Compare February 15, 2023 15:47
quake
quake reviewed Feb 16, 2023
View reviewed changes
sync/src/types/mod.rs Outdated Show resolved Hide resolved
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/notify_reject branch 2 times, most recently from eec4336 to 106e331 Compare February 16, 2023 02:05
driftluo
driftluo reviewed Feb 16, 2023
View reviewed changes
sync/src/types/mod.rs Outdated Show resolved Hide resolved
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/notify_reject branch from 106e331 to 5912a84 Compare February 16, 2023 07:42
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/notify_reject branch from 5912a84 to 14a41ae Compare February 16, 2023 08:16
@zhangsoledad zhangsoledad added this pull request to the merge queue Feb 26, 2023
Merged via the queue into nervosnetwork:develop with commit 1ba4ba6 Feb 26, 2023
@doitian doitian mentioned this pull request Apr 13, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake left review comments

@driftluo driftluo driftluo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangsoledad @quake @driftluo