Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deployment since #3772

Merged
merged 3 commits into from
Apr 8, 2023
Merged

feat: deployment since #3772

merged 3 commits into from
Apr 8, 2023

Conversation

zhangsoledad
Copy link
Member

What problem does this PR solve?

get_deployments_info rpc adds the returned period, threshold, and epoch which the current state started since.

Check List

Tests

  • Unit test
  • Integration test

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner December 26, 2022 08:50
@zhangsoledad zhangsoledad requested review from quake and removed request for a team December 26, 2022 08:50
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/deployment-info branch 2 times, most recently from 92de112 to 56ee3d3 Compare February 2, 2023 01:39
@zhangsoledad
Copy link
Member Author

nervosnetwork/rfcs#403

eval-exec
eval-exec reviewed Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@eval-exec eval-exec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please git rebase on develop branch.

doitian
doitian reviewed Apr 7, 2023
View reviewed changes
rpc/README.md Outdated Show resolved Hide resolved
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/deployment-info branch 2 times, most recently from 29803e6 to 9789c55 Compare April 7, 2023 06:50
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/deployment-info branch from 9789c55 to c5bdc6d Compare April 7, 2023 06:56
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/deployment-info branch from c5bdc6d to 464dad2 Compare April 7, 2023 07:01
@zhangsoledad zhangsoledad mentioned this pull request Apr 7, 2023
Closed
3 tasks
@zhangsoledad zhangsoledad added this pull request to the merge queue Apr 7, 2023
@zhangsoledad zhangsoledad mentioned this pull request Apr 7, 2023
Merged
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 7, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Apr 8, 2023
Merged via the queue into nervosnetwork:develop with commit 575bcad Apr 8, 2023
This was referenced Aug 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian left review comments

@quake quake quake left review comments

@eval-exec eval-exec eval-exec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangsoledad @quake @doitian @eval-exec