feat: thread-safe vm #3752
Merged
feat: thread-safe vm #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
force-pushed
the
zhangsoledad/upgrade-vm
branch
from
3a2a584 to
fafe86a
Compare
zhangsoledad
force-pushed
the
zhangsoledad/upgrade-vm
branch
from
584b18a to
859f98f
Compare
zhangsoledad
force-pushed
the
zhangsoledad/upgrade-vm
branch
from
859f98f to
7d03975
Compare
zhangsoledad
force-pushed
the
zhangsoledad/upgrade-vm
branch
from
7d03975 to
3aa3051
Compare
eval-exec
approved these changes
Mar 2, 2023
driftluo
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Upgrade ckb-vm to v0.23.2
What is changed and how it works?
nervosnetwork/ckb-vm#299
According to nervosnetwork/ckb-vm#299, ckb-vm adds Send and Sync bound to
InstructionCycleFunc,Debugger,Syscalls, and goes further to thread-safe by eliminating lifetime.The CKB side upgrade, need to rewrite the Syscalls to be Send or Sync.
There are some gray areas where some types are theoretically not Sync, such as store_transaction, and for this PR it would be too far to go to fix these issues, currently we can guarantee that store_transaction will not be modified concurrently, so it is safe.
Related changes
owner/repo:Check List
Tests
Release note