feat: Use 2 phase commit to solve DAO's lock period issue #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxuejie
force-pushed
the
2-phase-dao-adjustment
branch
from
bb40de5 to
ef4f94f
Compare
xxuejie
force-pushed
the
2-phase-dao-adjustment
branch
from
ef4f94f to
719f22f
Compare
keroro520
previously requested changes
Oct 25, 2019
keroro520
approved these changes
Oct 26, 2019
zhangsoledad
approved these changes
Oct 26, 2019
doitian
previously requested changes
Oct 28, 2019
|
Merge first. I'll keep reviewing it later. |
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Oct 29, 2019
1763: fix: fix cli output and ban reason r=quake a=driftluo 1. fix #1746 2. add reason on `ban_peer` in cx trait 1769: feat: Adapt to 2-phase Nervos DAO implementation r=doitian a=xxuejie Depends on nervosnetwork/ckb-system-scripts#59 Co-authored-by: driftluo <[email protected]> Co-authored-by: Xuejie Xiao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: