npm_installer: Skip creating package.json #410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the name in the `package.json` file generated by `npm init` matched the name of one of the packages to be installed, npm would error out. It turns out that npm will happily install packages without the current directory containing a `package.json`, so just do that instead of any gymnastics to avoid name the name collision. fixes neovim#409
kamalmarhubi
force-pushed
the
patch-1
branch
from
6192688 to
081fc32
Compare
|
I'm realising that #334 means this should probably not get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the name in the
package.jsonfile generated bynpm initmatched the name of one of the packages to be installed, npm would
error out. It turns out that npm will happily install packages without
the current directory containing a
package.json, so just do thatinstead of any gymnastics to avoid name the name collision.
fixes #409