Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startpage for the search engine #419

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

neon-mmd
Copy link
Owner

@neon-mmd neon-mmd commented Dec 5, 2023

What does this PR do?

This PR provides the startpage upstream search engine.

Why is this change important?

This PR is essential, as adding more engines will provide more diverse search results for the user, which improves the user experience.

How to test this PR locally?

It can be tested by installing and running Websurfx as mentioned in the docs and on the readme and by launching the browser and thoroughly testing. By selecting the Startpage search engine from the settings page or by setting it in the config. Then checking whether the results are being provided from the Startpage search engine or not.

Author's checklist

  • Provide the Startpage upstream search engine
  • Provide the Startpage engine as an option in the config
  • Bump the app version to v1.4.0

Related issues

Closes #314

Copy link
Collaborator

@alamin655 alamin655 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Let's merge this in. 👍

@alamin655 alamin655 merged commit 4cd1810 into rolling Dec 6, 2023
9 checks passed
@mergify mergify bot deleted the FEAT/314_startpage-for-the-search-engine branch December 6, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Startpage for the search engine
2 participants