Fix receiveTimeout behaviour
#903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of the `timeout` was not considering if requests were being treated by the server or not. This behaviour causes connections being wrongly close by inactivity. For fixing this issue, the `timeout` configuration changed to only be applied whenever there are ongoing requests.
fbiville
reviewed
Mar 23, 2022
packages/bolt-connection/test/channel/node/node-channel.test.js
Outdated
Show resolved
Hide resolved
fbiville
approved these changes
Mar 24, 2022
bigmontz
added a commit
to bigmontz/neo4j-javascript-driver
that referenced
this pull request
Mar 24, 2022
The previous implementation of the `timeout` was not considering if requests were being treated by the server or not. This behaviour causes connections being wrongly close by inactivity. For fixing this issue, the `timeout` configuration changed to only be applied whenever there are ongoing requests.
bigmontz
added a commit
that referenced
this pull request
Mar 24, 2022
The previous implementation of the `timeout` was not considering if requests were being treated by the server or not. This behaviour causes connections being wrongly close by inactivity. For fixing this issue, the `timeout` configuration changed to only be applied whenever there are ongoing requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of the
timeoutwas not considering if requests were being treated by the server or not.This behaviour causes connections being wrongly close by inactivity.
For fixing this issue, the
timeoutconfiguration changed to only be applied whenever there are ongoing requests.