Fix some TypeScript errors found with TypeScript 4.5 / Deno #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradenmacdonald
commented
Dec 23, 2021
bradenmacdonald
commented
Dec 23, 2021
bradenmacdonald
commented
Dec 23, 2021
bradenmacdonald
commented
Dec 23, 2021
bradenmacdonald
commented
Dec 23, 2021
bigmontz
requested changes
Dec 29, 2021
|
Hmm, I see there is now a CI error but I'm not sure what it is. |
bigmontz
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was working on a Deno driver for Neo4j that uses this codebase, I ran into some Typescript errors which this PR fixes.
These could be only relevant with the newer version of TypeScript (4.5) or with Deno's stricter
tsconfigdefaults, but I tried to fix them in a way that will work with Node and other versions/configurations of TypeScript without issues.I'll put explanations of each change inline.