Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#315] Fixes PathSegment constructor #316

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Conversation

slapersonne
Copy link
Contributor

  • Fixes rel property name in setter of constructor

@lutovich
Copy link
Contributor

lutovich commented Dec 21, 2017

Hi @slapersonne,

Thanks a lot for reporting this!

I think this issue should instead be fixed in TypeScript declaration file here https://github.com/neo4j/neo4j-javascript-driver/blob/1.6/types/v1/graph-types.d.ts#L66. Otherwise backwards compatibility will break when problem is fixed in JS source. Could you please change this PR to fix TS declaration instead?

To be able to merge your changes we will need a signed CLA from you.
See http://neo4j.com/developer/cla/ for further information.
Additional information on contributing code is found at
http://neo4j.com/developer/contributing-code/

@slapersonne
Copy link
Contributor Author

Thank you for your quick answer @lutovich.
I updated this PR accordingly and agreed the CLA.
Please feel free to let me know if something else is missing.

@lutovich
Copy link
Contributor

@slapersonne changes look good to me and we've received the CLA. Thanks!

Could you please squash all commits in one and use the same git account as connected to your github? Our contributor verification is going a bit crazy because of last two commits. Build is red because of this. Sorry.

@slapersonne slapersonne deleted the patch-1 branch December 21, 2017 18:26
@slapersonne slapersonne restored the patch-1 branch December 21, 2017 18:26
@slapersonne slapersonne reopened this Dec 21, 2017
@lutovich lutovich changed the base branch from 1.6 to 1.5 December 21, 2017 21:11
@lutovich lutovich changed the base branch from 1.5 to 1.6 December 21, 2017 21:11
@slapersonne
Copy link
Contributor Author

slapersonne commented Dec 22, 2017

@lutovich No problem, that should be correct now.
Do not hesitate to tell me is something else is bad or missing.

@lutovich lutovich merged commit 7b08bc5 into neo4j:1.6 Dec 22, 2017
@lutovich
Copy link
Contributor

Thanks for the fix @slapersonne!
PR now merged and commit cherry-picked to 1.5 branch with 47f5875.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants