Deprecate connectionPoolSize config setting #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-ince
reviewed
Oct 4, 2017
zhenlineo
reviewed
Oct 4, 2017
src/v1/internal/pool-config.js
Outdated
|
|
||
| if (maxIdleSizeConfigured && maxSizeConfigured) { | ||
| // both settings are configured - use configured values | ||
| maxIdleSize = config.connectionPoolSize; |
There was a problem hiding this comment.
I get same confused as @ali-ince
I thought we just deprecate maxIdle, why we still have two values?
If we want to keep maxIdle, then we should also add maxIdleConnectionPoolSize into config, right? otherwise, we have no reason to keep both two values here, right?
|
@ali-ince @zhenlineo you are right, we should probably just point |
In favour of `maxConnectionPoolSize`. Extracted pool config in a dedicated class which contains logic of handling now deprecated `connectionPoolSize` and new `maxConnectionPoolSize`. Added `maxConnectionPoolSize` to TypeScript declaration. Made code use `console.warn` instead of `console.log` for deprecation warnings. Updated test neo4j version to 3.2.5 and allowed stress test run a bit longer.
Now it will only have maxSize.
lutovich
force-pushed
the
1.5-pool-configs
branch
from
62d63e1 to
f644ce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favour of
maxConnectionPoolSize. Extracted pool config in a dedicated class which contains logic of handling now deprecatedconnectionPoolSizeand newmaxConnectionPoolSize. AddedmaxConnectionPoolSizeto TypeScript declaration. Made code useconsole.warninstead ofconsole.logfor deprecation warnings. Updated test neo4j version to 3.2.5 and allowed stress test run a bit longer.Currently default value of
maxConnectionPoolSizeis set to 50. This corresponds to previously default value ofconnectionPoolSize. We might tune this default in future.