Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export all available types and interfaces #280

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

lutovich
Copy link
Contributor

@lutovich lutovich commented Aug 7, 2017

This PR makes index TypeScript declaration export possible user-facing types/interfaces so that they can be used without directly importing files form types folder.

Example:

import neo4j from "neo4j-driver";

const driver: neo4j.Driver = neo4j.driver("bolt://localhost");
const session: neo4j.Session = driver.session();
...

Fixes #270.

@janwo, @pocesar your review would be super valuable :)

This commit makes index TypeScript declaration export possible
user-facing types/interfaces so that they can be used without
directly importing files form `types` folder.

Example:

```
import neo4j from "neo4j-driver";

const driver: neo4j.Driver = neo4j.driver("bolt://localhost");
const session: neo4j.Session = driver.session();
...
```
@pocesar
Copy link
Contributor

pocesar commented Aug 8, 2017

LGTM. this PR empowers library creators that use TS and neo4j internals 👍

@lutovich lutovich merged commit 82af0d8 into neo4j:1.4 Aug 8, 2017
@lutovich lutovich deleted the 1.4-ts-imports branch August 8, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants