Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap integer.d.ts with module #272

Closed
wants to merge 1 commit into from
Closed

Wrap integer.d.ts with module #272

wants to merge 1 commit into from

Conversation

janwo
Copy link

@janwo janwo commented Jul 15, 2017

Wrapping a module around integer to solve #270.

@janwo janwo changed the title Wrap with module Wrap integer.d.ts with module Jul 15, 2017
@pocesar
Copy link
Contributor

pocesar commented Jul 15, 2017

this isn't correct, since you're mixing module declaration types and the rest of the files uses exports

@lutovich
Copy link
Contributor

@janwo I tried this change on your neo4j-test project and it does not seem to help. Am I missing something?

@janwo
Copy link
Author

janwo commented Jul 17, 2017

@lutovich It did work for me. Whats the error?

@lutovich
Copy link
Contributor

@janwo never mind, I did not change the import. It works. I'm not entirely sure what exactly does this change mean. Maybe all declaration files should define modules like this?

@pocesar what do you think?

@janwo janwo closed this Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants