Least connected load balancing strategy #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will now track count of active (checked out of the pool) resources per key. Where key is a server address in the driver. Counter is incremented when resource is acquired from the pool and decremented when resource is released back to the pool. Also added JSDocs in the `Pool` class.
lutovich
force-pushed
the
1.5-least-connected-lb
branch
from
ec52f96 to
8378026
Compare
This replaces the existing round-robin. It gives us better performance
with clusters composed of different machine capacities.
Lease connected load balancing strategy selects start index in
round-robin fashion to avoid always selecting same machine when cluster
does not have any running transactions or all machines have same number
of active connections.
It is possible to go back to previous round-robin load balancing
strategy using an experimental config setting:
```
{loadBalancingStrategy: 'round_robin'}
```
lutovich
force-pushed
the
1.5-least-connected-lb
branch
from
8378026 to
576d9b4
Compare
lutovich
force-pushed
the
1.5-least-connected-lb
branch
from
576d9b4 to
c7281ce
Compare
praveenag
approved these changes
Jul 12, 2017
praveenag
suggested changes
Jul 12, 2017
test/v1/routing-driver.test.js
Outdated
| const strategy = RoutingDriver._createLoadBalancingStrategy({loadBalancingStrategy: 'round_robin'}, new Pool()); | ||
| expect(strategy instanceof RoundRobinLoadBalancingStrategy).toBeTruthy(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This is missing a test case for 'Unknown load balancing strategy
|
@praveenag test added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the existing round-robin. It gives us better performance with clusters composed of different machine capacities. Lease connected load balancing strategy selects start index in round robin fashion to avoid always selecting same machine when cluster does not have any running transactions or all machines have same number of active connections.
It is possible to go back to previous round-robin load balancing strategy using an experimental config setting: