-
Notifications
You must be signed in to change notification settings - Fork 147
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added least connected load balancing strategy
This replaces the existing round-robin. It gives us better performance
with clusters composed of different machine capacities.
Lease connected load balancing strategy selects start index in
round-robin fashion to avoid always selecting same machine when cluster
does not have any running transactions or all machines have same number
of active connections.
It is possible to go back to previous round-robin load balancing
strategy using an experimental config setting:
```
{loadBalancingStrategy: 'round_robin'}
```- Loading branch information
Showing
10 changed files
with
304 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
src/v1/internal/least-connected-load-balancing-strategy.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /** | ||
| * Copyright (c) 2002-2017 "Neo Technology,"," | ||
| * Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| import RoundRobinArrayIndex from './round-robin-array-index'; | ||
| import LoadBalancingStrategy from './load-balancing-strategy'; | ||
|
|
||
| export const LEAST_CONNECTED_STRATEGY_NAME = 'least_connected'; | ||
|
|
||
| export default class LeastConnectedLoadBalancingStrategy extends LoadBalancingStrategy { | ||
|
|
||
| /** | ||
| * @constructor | ||
| * @param {Pool} connectionPool the connection pool of this driver. | ||
| */ | ||
| constructor(connectionPool) { | ||
| super(); | ||
| this._readersIndex = new RoundRobinArrayIndex(); | ||
| this._writersIndex = new RoundRobinArrayIndex(); | ||
| this._connectionPool = connectionPool; | ||
| } | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| selectReader(knownReaders) { | ||
| return this._select(knownReaders, this._readersIndex); | ||
| } | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| selectWriter(knownWriters) { | ||
| return this._select(knownWriters, this._writersIndex); | ||
| } | ||
|
|
||
| _select(addresses, roundRobinIndex) { | ||
| const length = addresses.length; | ||
| if (length === 0) { | ||
| return null; | ||
| } | ||
|
|
||
| // choose start index for iteration in round-rodin fashion | ||
| const startIndex = roundRobinIndex.next(length); | ||
| let index = startIndex; | ||
|
|
||
| let leastConnectedAddress = null; | ||
| let leastActiveConnections = Number.MAX_SAFE_INTEGER; | ||
|
|
||
| // iterate over the array to find least connected address | ||
| do { | ||
| const address = addresses[index]; | ||
| const activeConnections = this._connectionPool.activeResourceCount(address); | ||
|
|
||
| if (activeConnections < leastActiveConnections) { | ||
| leastConnectedAddress = address; | ||
| leastActiveConnections = activeConnections; | ||
| } | ||
|
|
||
| // loop over to the start of the array when end is reached | ||
| if (index === length - 1) { | ||
| index = 0; | ||
| } else { | ||
| index++; | ||
| } | ||
| } | ||
| while (index !== startIndex); | ||
|
|
||
| return leastConnectedAddress; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
135 changes: 135 additions & 0 deletions
135
test/internal/least-connected-load-balancing-strategy.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| /** | ||
| * Copyright (c) 2002-2017 "Neo Technology,"," | ||
| * Network Engine for Objects in Lund AB [http://neotechnology.com] | ||
| * | ||
| * This file is part of Neo4j. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import LeastConnectedLoadBalancingStrategy from '../../src/v1/internal/least-connected-load-balancing-strategy'; | ||
| import Pool from '../../src/v1/internal/pool'; | ||
|
|
||
| describe('LeastConnectedLoadBalancingStrategy', () => { | ||
|
|
||
| it('should return null when no readers', () => { | ||
| const knownReaders = []; | ||
| const strategy = new LeastConnectedLoadBalancingStrategy(new DummyPool({})); | ||
|
|
||
| expect(strategy.selectReader(knownReaders)).toBeNull(); | ||
| }); | ||
|
|
||
| it('should return null when no writers', () => { | ||
| const knownWriters = []; | ||
| const strategy = new LeastConnectedLoadBalancingStrategy(new DummyPool({})); | ||
|
|
||
| expect(strategy.selectWriter(knownWriters)).toBeNull(); | ||
| }); | ||
|
|
||
| it('should return same reader when it is the only one available and has no connections', () => { | ||
| const knownReaders = ['reader-1']; | ||
| const strategy = new LeastConnectedLoadBalancingStrategy(new DummyPool({'reader-1': 0})); | ||
|
|
||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-1'); | ||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-1'); | ||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-1'); | ||
| }); | ||
|
|
||
| it('should return same writer when it is the only one available and has no connections', () => { | ||
| const knownWriters = ['writer-1']; | ||
| const strategy = new LeastConnectedLoadBalancingStrategy(new DummyPool({'writer-1': 0})); | ||
|
|
||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-1'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-1'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-1'); | ||
| }); | ||
|
|
||
| it('should return same reader when it is the only one available and has active connections', () => { | ||
| const knownReaders = ['reader-1']; | ||
| const strategy = new LeastConnectedLoadBalancingStrategy(new DummyPool({'reader-1': 14})); | ||
|
|
||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-1'); | ||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-1'); | ||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-1'); | ||
| }); | ||
|
|
||
| it('should return same writer when it is the only one available and has active connections', () => { | ||
| const knownWriters = ['writer-1']; | ||
| const strategy = new LeastConnectedLoadBalancingStrategy(new DummyPool({'writer-1': 3})); | ||
|
|
||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-1'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-1'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-1'); | ||
| }); | ||
|
|
||
| it('should return readers in round robin order when no active connections', () => { | ||
| const knownReaders = ['reader-1', 'reader-2', 'reader-3']; | ||
| const pool = new DummyPool({'reader-1': 0, 'reader-2': 0, 'reader-3': 0}); | ||
| const strategy = new LeastConnectedLoadBalancingStrategy(pool); | ||
|
|
||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-1'); | ||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-2'); | ||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-3'); | ||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-1'); | ||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-2'); | ||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-3'); | ||
| }); | ||
|
|
||
| it('should return writers in round robin order when no active connections', () => { | ||
| const knownWriters = ['writer-1', 'writer-2', 'writer-3', 'writer-4']; | ||
| const pool = new DummyPool({'writer-1': 0, 'writer-2': 0, 'writer-3': 0, 'writer-4': 0}); | ||
| const strategy = new LeastConnectedLoadBalancingStrategy(pool); | ||
|
|
||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-1'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-2'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-3'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-4'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-1'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-2'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-3'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-4'); | ||
| }); | ||
|
|
||
| it('should return least connected reader', () => { | ||
| const knownReaders = ['reader-1', 'reader-2', 'reader-3']; | ||
| const pool = new DummyPool({'reader-1': 7, 'reader-2': 3, 'reader-3': 8}); | ||
| const strategy = new LeastConnectedLoadBalancingStrategy(pool); | ||
|
|
||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-2'); | ||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-2'); | ||
| expect(strategy.selectReader(knownReaders)).toEqual('reader-2'); | ||
| }); | ||
|
|
||
| it('should return least connected writer', () => { | ||
| const knownWriters = ['writer-1', 'writer-2', 'writer-3', 'writer-4']; | ||
| const pool = new DummyPool({'writer-1': 5, 'writer-2': 4, 'writer-3': 6, 'writer-4': 2}); | ||
| const strategy = new LeastConnectedLoadBalancingStrategy(pool); | ||
|
|
||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-4'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-4'); | ||
| expect(strategy.selectWriter(knownWriters)).toEqual('writer-4'); | ||
| }); | ||
|
|
||
| }); | ||
|
|
||
| class DummyPool extends Pool { | ||
|
|
||
| constructor(activeConnections) { | ||
| super(() => 42); | ||
| this._activeConnections = activeConnections; | ||
| } | ||
|
|
||
| activeResourceCount(key) { | ||
| return this._activeConnections[key]; | ||
| } | ||
| } |
Oops, something went wrong.