Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use xfail instead of NotImplementedError to skip tests unsupported by an algebra #281

Open
jgosmann opened this issue Apr 18, 2021 · 0 comments · May be fixed by #291
Open

Use xfail instead of NotImplementedError to skip tests unsupported by an algebra #281

jgosmann opened this issue Apr 18, 2021 · 0 comments · May be fixed by #291
Assignees
@jgosmann

Comments

@jgosmann
Copy link
Collaborator

See this comment.

I will leave except NotImplementedError -> pass as is in this PR to keep it focused on the binding powers. Though, after thinking a bit about this, I think that xfail would be correct approach here. However, this is not completely trivial. Currently, the NotImplementedError is used to detect if a feature is unsupported. When using xfail this should be known a-priori (so that we can differentiate between "not yet implemented" and "intentionally not implemented/unsupported"). This might involve adding a way for algebras to declare their "supported features".
@jgosmann jgosmann added this to the 1.3.0 milestone Apr 18, 2021
@jgosmann jgosmann self-assigned this Nov 6, 2021
jgosmann added a commit that referenced this issue Nov 6, 2021
@jgosmann
Use xfail instead of silently passing tests
4a370e5 
This makes it more clear when certain features are not supported by an
algebra.

To be able to use xfail, this adds a mechanism to declare what sidedness
values are supported by specfic algebra operations. This mechanism is
a decorator which adds an attribute with the allowed sidedness values to
the method object.

Closes #281.
@jgosmann jgosmann linked a pull request Nov 6, 2021 that will close this issue
Open
4 tasks
jgosmann added a commit that referenced this issue Nov 6, 2021
@jgosmann
Use xfail instead of silently passing tests
d9aeee2 
This makes it more clear when certain features are not supported by an
algebra.

To be able to use xfail, this adds a mechanism to declare what sidedness
values are supported by specfic algebra operations. This mechanism is
a decorator which adds an attribute with the allowed sidedness values to
the method object.

Closes #281.
jgosmann added a commit that referenced this issue Nov 7, 2021
@jgosmann
Use xfail instead of silently passing tests
844ed18 
This makes it more clear when certain features are not supported by an
algebra.

To be able to use xfail, this adds a mechanism to declare what sidedness
values are supported by specfic algebra operations. This mechanism is
a decorator which adds an attribute with the allowed sidedness values to
the method object.

Closes #281.
jgosmann added a commit that referenced this issue Nov 9, 2021
@jgosmann
Use xfail instead of silently passing tests
65ceb15 
This makes it more clear when certain features are not supported by an
algebra.

To be able to use xfail, this adds a mechanism to declare what sidedness
values are supported by specfic algebra operations. This mechanism is
a decorator which adds an attribute with the allowed sidedness values to
the method object.

Closes #281.
jgosmann added a commit that referenced this issue Nov 13, 2021
@jgosmann
Use xfail instead of silently passing tests
c5f250a 
This makes it more clear when certain features are not supported by an
algebra.

To be able to use xfail, this adds a mechanism to declare what sidedness
values are supported by specfic algebra operations. This mechanism is
a decorator which adds an attribute with the allowed sidedness values to
the method object.

Closes #281.
jgosmann added a commit that referenced this issue Nov 13, 2021
@jgosmann
Use xfail instead of silently passing tests
817dc5b 
This makes it more clear when certain features are not supported by an
algebra.

To be able to use xfail, this adds a mechanism to declare what sidedness
values are supported by specfic algebra operations. This mechanism is
a decorator which adds an attribute with the allowed sidedness values to
the method object.

Closes #281.
jgosmann added a commit that referenced this issue Nov 13, 2021
@jgosmann
Use xfail instead of silently passing tests
0a3d99a 
This makes it more clear when certain features are not supported by an
algebra.

To be able to use xfail, this adds a mechanism to declare what sidedness
values are supported by specfic algebra operations. This mechanism is
a decorator which adds an attribute with the allowed sidedness values to
the method object.

Closes #281.
@jgosmann jgosmann removed this from the 1.3.0 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgosmann jgosmann

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use xfail instead of silently passing tests nengo/nengo-spa
1 participant
@jgosmann