Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NativeLoader non-final #681

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Make NativeLoader non-final #681

merged 1 commit into from
Mar 7, 2017

Conversation

dantleech
Copy link
Contributor

As discussed, this PR makes the NativeLoader non-final in order that it can be extended.

@dantleech
Copy link
Contributor Author

Shall we rename protected createBuiltIn.* to protected create.* instead?

@theofidry
Copy link
Member

Shall we rename protected createBuiltIn.* to protected create.* instead?

Yeah, makes sense. Let's do it in this PR as well

@dantleech
Make NativeLoader non-final and changed API
f566060 
- Made NativeLoader non-final
- Removed "BuiltIn" from the NativeLoader
@dantleech dantleech force-pushed the make_native_loader_final branch from f823a55 to f566060 Compare March 7, 2017 19:32
@dantleech
Copy link
Contributor Author

Done - I didn't realise that you could call $loader->getXxx externally, so its a "BC" break.

@theofidry theofidry merged commit 4acd0d6 into nelmio:master Mar 7, 2017
@theofidry
Copy link
Member

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantleech @theofidry