Mark the expression language as internal #600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Expression Language is still relatively new and in-house. It may be possible that another library like https://github.com/hoaproject/Compiler may help a lot and replace a huge chunk of it. As such, I don't think I want to make this part of the library public and be potentially able to change it even after a stable release.
That said, this part of the API leaks to the ValueResolvers, which makes them rather unstable. So I am not sure if this is actually doable.
@tshelburne thoughts?