Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the expression language as internal #600

Merged

Conversation

theofidry
Copy link
Member

The Expression Language is still relatively new and in-house. It may be possible that another library like https://github.com/hoaproject/Compiler may help a lot and replace a huge chunk of it. As such, I don't think I want to make this part of the library public and be potentially able to change it even after a stable release.

That said, this part of the API leaks to the ValueResolvers, which makes them rather unstable. So I am not sure if this is actually doable.

@tshelburne thoughts?

@tshelburne
Copy link
Collaborator

The idea makes sense to me - it's always good to clarify intentions. I would say just create a ticket with RFC to look at alternatives, like the compiler above, and mention the issue with value resolvers there. That way the problem is memorialized for future work, but we can keep things as clear as possible in the present.

@theofidry theofidry merged commit a9effa3 into nelmio:master Nov 4, 2016
@theofidry theofidry deleted the bugfix/expression-language-internal branch November 4, 2016 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants