Fix usage of empty values with Faker provider #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to some laxist checks done for a custom Faker provider function arguments, if empty values are passed, it is passing as if no arguments has been given. This PR enforce stricter checks and add a test case for it. Closes nelmio#196.
theofidry
added a commit
to theofidry/alice
that referenced
this pull request
Jul 16, 2016
* 2.x: (24 commits) Update changlog for 2.2.2 Fix support for hyphens (nelmio#431) TypeHintChecker tweaks (nelmio#430) Update changelog for 2.2.1 Add tests for Typehints in setters (nelmio#427) Fix usage of empty values with Faker provider (nelmio#426) Add tests for templates declared in includes (nelmio#424) Fix composite parameters (nelmio#423) Fix typo about $fake closure (nelmio#422) Tweaks on the CHANGELOG Fix minimum PHP version requred Update CHANGELOG Update composer.json Fix unique flag usage with templates Harden parameters and references (nelmio#355) Fix quotes (nelmio#417) Fix identity example (nelmio#416) Drop support for PHP 5.4 and 5.5. (nelmio#414) Doc tweaks (nelmio#412) Cleanup LoaderTest (nelmio#413) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some laxist checks done for a custom Faker provider function arguments, if empty values are passed, it is passing as if no arguments has been given. This PR enforce stricter checks and add a test case for it.
Closes #196.