Fixed deprecation warnings #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the work @pkruithof!
Could you remove that part? Logger is an optional dependency and the library works fine without it :) |
|
Done. |
| /** | ||
| * @param string $plural | ||
| * | ||
| * @return string |
|
I'll apply your other feedback tomorrow when I have more time. |
| // cache the singularize method | ||
| $this->singularizer = [$class, $method]; | ||
|
|
||
| break; |
There was a problem hiding this comment.
in this case a return would be more clear IMO
|
Alright, a last change and it's ready to go :) |
|
Closed via 10674cb, thanks a lot for the work @pkruithof :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389, and also warnings from phpunit.
I also added a psr/log dependency, as it's being used in the Loader class.