Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CompilerPass to check if framework_bundle.property_access is enabled #1124

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

xElysioN
Copy link
Contributor

@xElysioN xElysioN commented Nov 8, 2022

This allows to have a more user-friendly error when the framework_bundle.property_access is disabled.

This allows to have a more user-friendly error when the framework_bundle.property_access is disabled.
Copy link
Member

@theofidry theofidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I completely forgot about that setting and that explains a few issues that popped up over time. Thanks a lot :)

@xElysioN xElysioN requested a review from theofidry November 14, 2022 17:52
@theofidry theofidry merged commit e7d3275 into nelmio:master Nov 14, 2022
@theofidry
Copy link
Member

Thank you @xElysioN!

@xElysioN xElysioN deleted the patch-1 branch November 15, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants