Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse references in quotes #487

Closed
theofidry opened this issue Aug 3, 2016 · 1 comment
Closed

Parse references in quotes #487

theofidry opened this issue Aug 3, 2016 · 1 comment
Milestone

Comments

@theofidry
Copy link
Member

It seems that this has been added to support the switch to '@ref' for the YAML parser but it actually shouldn't be needed. To be checked and see if this feature should be deprecated in 2.x or not.

public function testLoadParsesReferencesInQuotes()
    {
        $res = $this->loadData([
            self::USER => [
                'user1' => [
                    'username' => 'alice',
                ],
            ],
            self::GROUP => [
                'a' => [
                    'members' => ['\'@user1\'']
                ],
            ],
        ]);
        /** @var Group $group */
        $group = $res['a'];

        $this->assertInstanceOf(self::USER, current($group->getMembers()));
        $this->assertEquals('alice', current($group->getMembers())->username);
    }
@theofidry theofidry added this to the 2.x milestone Aug 3, 2016
theofidry added a commit that referenced this issue Sep 15, 2016
Deprecate references in quotes

Closes #487.
@theofidry
Copy link
Member Author

Closed via #566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant