Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated persistence to work with latest mkdirp. Pulled events back in… #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bnielsen1965
Copy link

…to Datastore to fix multiple bugs due to missing emit and on functions. Fixed db test that was failing due to unhandledRejection exception.

This was originally meant to resolve breakage caused by the latest mkdirp but several tests also no longer worked so I added in those fixes as well.

…to Datastore to fix multiple bugs due to missing emit and on functions. Fixed db test that was failing due to unhandledRejection exception.
@bnielsen1965
Copy link
Author

bnielsen1965 commented Feb 8, 2021

@pi0 Can you update the travis settings on your repo to use travis.com in place of travis.org? They are ending the travis.org domain use and builds will be slow or potentially not work on the .org domain anymore.

Also, if this pull request passes after switching to travis.com can you do a review to see if you can accept it?

The latest mkdirp package had changes that broke nedb-core and it will require nodejs 10 or higher.

Thanks,
Bryan

EDIT: travis check completed and failed, looking into the issue...

EDIT 2: The problem is that travis is building the last master commit not the PR so the build fails as expected on the mkdirp. The PR fixes this but is not being tested by travis.

Are PR builds enabled in the settings? If I run tests locally on the PR they all pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant